carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1665: [CARBONDATA-1884] Add CTAS support to carbond...
Date Sun, 17 Dec 2017 02:19:13 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1665#discussion_r157356143
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
    @@ -210,13 +211,40 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser)
           }
         }
     
    -    val fields = parser.getFields(cols ++ partitionByStructFields)
    +    var fields = parser.getFields(cols ++ partitionByStructFields)
         val options = new CarbonOption(properties)
         // validate tblProperties
         val bucketFields = parser.getBucketFields(tableProperties, fields, options)
     
         validateStreamingProperty(options)
     
    +    // validate for create table as select
    --- End diff --
    
    move this logic to a validateSelectQueryForCTAS function


---

Mime
View raw message