carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1653: [CARBONDATA-1893] Data load with multiple QUO...
Date Thu, 14 Dec 2017 17:25:22 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1653#discussion_r157009247
  
    --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dataload/TestLoadOptions.scala
---
    @@ -0,0 +1,83 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.spark.testsuite.dataload
    +
    +import org.apache.spark.sql.test.util.QueryTest
    +import org.scalatest.BeforeAndAfterAll
    +
    +import org.apache.carbondata.spark.exception.MalformedCarbonCommandException
    +
    +class TestLoadOptions extends QueryTest with BeforeAndAfterAll{
    +
    +  override def beforeAll {
    +    sql("drop table if exists TestLoadTableOptions")
    +    sql("CREATE table TestLoadTableOptions (ID int, date String, country String, name
String," +
    +        "phonetype String, serialname String, salary int) stored by 'org.apache.carbondata.format'")
    +
    +  }
    +
    +  override def afterAll {
    +    sql("drop table if exists TestLoadTableOptions")
    +  }
    +
    +
    +  test("test load data with more than one char in quotechar option") {
    +    val errorMessage = intercept[MalformedCarbonCommandException] {
    +      sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/dataretention1.csv' INTO TABLE " +
    +          s"TestLoadTableOptions OPTIONS('QUOTECHAR'='\\\\')")
    +    }.getMessage
    +    assert(errorMessage.equals("Quotation cannot be more than one character."))
    +  }
    +
    +  test("test load data with more than one char in commentchar option") {
    +    val errorMessage = intercept[MalformedCarbonCommandException] {
    +      sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/dataretention1.csv' INTO TABLE " +
    +          s"TestLoadTableOptions OPTIONS('COMMENTCHAR'='##')")
    +      assert(false)
    +    }.getMessage
    +    assert(errorMessage.equals("Comment marker cannot be more than one character."))
    +  }
    +
    +  test("test load data with more than one char in escapechar option") {
    +    val errorMessage = intercept[MalformedCarbonCommandException] {
    +      sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/dataretention1.csv' INTO TABLE " +
    +          s"TestLoadTableOptions OPTIONS('ESCAPECHAR'='\\\\')")
    +      assert(false)
    +    }.getMessage
    +    assert(errorMessage.equals("Escape character cannot be more than one character."))
    +  }
    +
    +  test("test load data with invalid escape sequence in quotechar option") {
    +    val errorMessage = intercept[MalformedCarbonCommandException] {
    +      sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/dataretention1.csv' INTO TABLE " +
    +          s"TestLoadTableOptions OPTIONS('QUOTECHAR'='\\y')")
    +    }.getMessage
    +    assert(errorMessage.equals("Quotation cannot be more than one character."))
    +  }
    +
    +  test("test load data with with valid escape sequence in quotechar option") {
    +    sql(s"LOAD DATA LOCAL INPATH '$resourcesPath/dataretention1.csv' INTO TABLE " +
    +        s"TestLoadTableOptions OPTIONS('QUOTECHAR'='\\n')")
    --- End diff --
    
    Replace quotechar with escapechar in above 2 test cases


---

Mime
View raw message