carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kunal642 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1622: [CARBONDATA-1865] Refactored code to skip sin...
Date Tue, 12 Dec 2017 09:01:30 GMT
Github user kunal642 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1622#discussion_r156304089
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala
---
    @@ -160,7 +160,7 @@ case class CarbonLoadDataCommand(
             if (isOverwriteTable) {
               LOGGER.info(s"Overwrite of carbon table with $dbName.$tableName is in progress")
             }
    -        if (carbonLoadModel.getLoadMetadataDetails.isEmpty && carbonLoadModel.getUseOnePass
&&
    +        if (carbonLoadModel.getLoadMetadataDetails.size() == 1 && carbonLoadModel.getUseOnePass
&&
    --- End diff --
    
    This if condition can be remove as the high_cardinality check has been removed. 
    @manishgupta88 Please suggest


---

Mime
View raw message