carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1630: [CARBONDATA-1826] Carbon 1.3.0 - Spark 2.2: D...
Date Mon, 11 Dec 2017 17:02:11 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1630#discussion_r156134688
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
    @@ -175,6 +175,17 @@ object CarbonReflectionUtils {
         }
       }
     
    +  def getDescribeTableFormattedField[T: TypeTag : reflect.ClassTag](obj: T): Boolean
= {
    +    var isFormatted: Boolean = false
    +    val im = rm.reflect(obj)
    +    for (m <- typeOf[T].members.filter(!_.isMethod)) {
    +      if (m.toString.contains("isFormatted")) {
    +        isFormatted = im.reflectField(m.asTerm).get.asInstanceOf[Boolean]
    --- End diff --
    
    Once the condition is satisfied, exit the loop....Also can you try to use find method
here instead of using for loop..


---

Mime
View raw message