carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From geetikagupta16 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1601: [CARBONDATA-1787] Validation for table proper...
Date Fri, 08 Dec 2017 10:48:25 GMT
Github user geetikagupta16 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1601#discussion_r155749994
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
    @@ -190,7 +191,7 @@ class CarbonHelperSqlAstBuilder(conf: SQLConf, parser: CarbonSpark2SqlParser)
         }
     
         val tableProperties = mutable.Map[String, String]()
    -    properties.foreach{property => tableProperties.put(property._1, property._2)}
    +    validatedProperties.foreach{property => tableProperties.put(property._1, property._2)}
    --- End diff --
    
    Can't remove the Mutable Map as it is being updated in prepareTableModel method


---

Mime
View raw message