carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] carbondata pull request #1616: [CARBONDATA-1851][WIP] Code refactored for be...
Date Thu, 07 Dec 2017 09:39:53 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1616#discussion_r155470927
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
    @@ -126,6 +126,10 @@
       private static final String DATA_MAP_DSTR = "mapreduce.input.carboninputformat.datamapdstr";
       public static final String DATABASE_NAME = "mapreduce.input.carboninputformat.databaseName";
       public static final String TABLE_NAME = "mapreduce.input.carboninputformat.tableName";
    +  // to be used in cases where main table status file is not done and newly created segment
need to
    +  // be accessed
    +  public static final String FORCE_ACCESS_SEGMENT =
    +      "mapreduce.input.carboninputformat.force.access.segment";
    --- End diff --
    
    Dont needs a new flag, use getValidateSegmentsToAccess, mapreduce.input.carboninputformat.validsegments


---

Mime
View raw message