carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1595: [CARBONDATA-1868][Spark-2.2]Carbon-Spark2.2 I...
Date Thu, 07 Dec 2017 06:17:14 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1595#discussion_r155438305
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
    @@ -152,7 +165,19 @@ case class CarbonIUDAnalysisRule(sparkSession: SparkSession) extends
Rule[Logica
     
             val projList = Seq(UnresolvedAlias(UnresolvedStar(alias.map(Seq(_)))), tupleId)
             // include tuple id in subquery
    -        Project(projList, relation)
    +        if (sparkSession.version.startsWith("2.1")) {
    +          Project(projList, relation)
    +        } else if (sparkSession.version.startsWith("2.2")) {
    +          alias match {
    +            case Some(a) =>
    +              val subqueryAlias = CarbonReflectionUtils.getSubqueryAlias(sparkSession,
alias
    --- End diff --
    
    Format properly
    ```
    CarbonReflectionUtils.getSubqueryAlias(
       sparkSession,
       alias,
       relation, 
       Some(table.tableIdentifier))
    ```


---

Mime
View raw message