carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1626: [CARBONDATA-1519][PreAgg-Timeseries] Support ...
Date Wed, 06 Dec 2017 15:49:11 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1626#discussion_r155275089
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala
---
    @@ -38,8 +38,20 @@ object LoadPostAggregateListener extends OperationEventListener {
         val sparkSession = loadEvent.sparkSession
         val carbonLoadModel = loadEvent.carbonLoadModel
         val table = carbonLoadModel.getCarbonDataLoadSchema.getCarbonTable
    +    //    val parentTableName = table.getTableName
         if (table.hasDataMapSchema) {
    -      for (dataMapSchema: DataMapSchema <- table.getTableInfo.getDataMapSchemaList.asScala)
{
    +      // getting all the aggergate datamap schema
    +      val aggregationDataMapList = table.getTableInfo.getDataMapSchemaList.asScala
    --- End diff --
    
    simplify `table.getTableInfo.getDataMapSchemaList.asScala.filter(_.isInstanceOf[AggregationDataMapSchema]).map(_.asInstanceOf)`


---

Mime
View raw message