carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1626: [CARBONDATA-1519][PreAgg-Timeseries] Support ...
Date Wed, 06 Dec 2017 15:37:29 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1626#discussion_r155271321
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/preagg/AggregateTableSelector.java
---
    @@ -70,8 +70,15 @@ public AggregateTableSelector(QueryPlan queryPlan, CarbonTable parentTable)
{
             AggregationDataMapSchema aggregationDataMapSchema = (AggregationDataMapSchema)
dmSchema;
             isMatch = true;
             for (QueryColumn queryColumn : projectionColumn) {
    -          ColumnSchema columnSchemaByParentName = aggregationDataMapSchema
    -              .getNonAggChildColBasedByParent(queryColumn.getColumnSchema().getColumnName());
    +          ColumnSchema columnSchemaByParentName = null;
    --- End diff --
    
    Please refactor to remove duplicate code


---

Mime
View raw message