carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1583: [CARBONDATA-1822][Spark-Integration] Support ...
Date Wed, 06 Dec 2017 15:24:48 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1583#discussion_r155267373
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonMetaStore.scala
---
    @@ -142,6 +142,10 @@ trait CarbonMetaStore {
     
       def getTableFromMetadataCache(database: String, tableName: String): Option[CarbonTable]
     
    +  def getTableInfo(absoluteTableIdentifier: AbsoluteTableIdentifier)
    --- End diff --
    
    This idea is good, but I think you do not need to put this in CarbonMetaStore trait, right?
Reading schema from tablePath can be an utility.


---

Mime
View raw message