carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1626: [CARBONDATA-1519][PreAgg-Timeseries] Support ...
Date Wed, 06 Dec 2017 15:17:29 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1626#discussion_r155265299
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/AggregationDataMapSchema.java
---
    @@ -125,6 +179,25 @@ public ColumnSchema getAggChildColByParent(String columnName,
         return null;
       }
     
    +  /**
    +   * Below method will be used to get the column schema based on parent column name
    +   * @param columName
    +   *                parent column name
    +   * @return child column schema
    +   */
    +  public ColumnSchema getTimeseriesChildColByParent(String columName, String timeseriesFunction)
{
    --- End diff --
    
    I think it is duplicated to `getChildColByParentColName`, please remove it


---

Mime
View raw message