carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1626: [CARBONDATA-1519][PreAgg-Timeseries] Support ...
Date Wed, 06 Dec 2017 15:13:07 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1626#discussion_r155264012
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/AggregationDataMapSchema.java
---
    @@ -74,7 +86,49 @@ public ColumnSchema getNonAggChildColBasedByParent(String columnName)
{
           Iterator<ColumnSchema> iterator = columnSchemas.iterator();
           while (iterator.hasNext()) {
             ColumnSchema next = iterator.next();
    -        if (null == next.getAggFunction() || next.getAggFunction().isEmpty()) {
    +        if ((null == next.getAggFunction() || next.getAggFunction().isEmpty()) &&
null == next
    +            .getTimeSeriesFunction() || next.getTimeSeriesFunction().isEmpty()) {
    +          return next;
    +        }
    +      }
    +    }
    +    return null;
    +  }
    +
    +  /**
    +   * Below method will be used to get the columns on which aggregate function is not
applied
    --- End diff --
    
    change the description


---

Mime
View raw message