carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1624: [WIP][CARBONDATA-1867] Add support for task/s...
Date Wed, 06 Dec 2017 13:33:26 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1624#discussion_r155236681
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMap.java
---
    @@ -178,6 +191,26 @@ private void loadToUnsafe(DataFileFooter fileFooter, SegmentProperties
segmentPr
             throw new RuntimeException(e);
           }
         }
    +    // write the task level min/max row to unsafe memory store
    +    if (null != taskMinMaxRow) {
    +      addRowToUnsafeMemoryStore(taskMinMaxRow);
    +    }
    +  }
    +
    +  private void addRowToUnsafeMemoryStore(DataMapRow row) {
    --- End diff --
    
    I think better set some junk or default values exept for the minmax in case of last row.
so that it will be easy to read and write


---

Mime
View raw message