carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <...@git.apache.org>
Subject [GitHub] carbondata pull request #1583: [CARBONDATA-1822][Spark-Integration] Support ...
Date Tue, 05 Dec 2017 18:51:16 GMT
Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1583#discussion_r155041379
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
---
    @@ -320,13 +322,8 @@ class AlterTableColumnSchemaGenerator(
     // TODO: move this to carbon store API
     object TableNewProcessor {
       def apply(
    -      cm: TableModel,
    -      identifier: AbsoluteTableIdentifier): TableInfo = {
    -    new TableNewProcessor(
    -      cm,
    -      identifier.getDatabaseName,
    -      identifier.getTableName,
    -      identifier.getTablePath).process
    +      cm: TableModel): TableInfo = {
    --- End diff --
    
    We have to pass the TableInfo to the CarbonCreateTableCommand so that we can use the 
    CarbonCreateTableCommand  flow from the RefreshCarbonTableCommand.
    Any ways for supporting the external table path, the tablePath is being passed to CarbonCreateTableCommand


---

Mime
View raw message