carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1606: [CARBONDATA-1839] [DataLoad]Fix bugs in compr...
Date Tue, 05 Dec 2017 16:23:17 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1606#discussion_r154999120
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/sort/impl/ParallelReadMergeSorterImpl.java
---
    @@ -80,11 +81,7 @@ public void initialize(SortParameters sortParameters) {
             File.separator, CarbonCommonConstants.SORT_TEMP_FILE_LOCATION);
         finalMerger =
             new SingleThreadFinalSortFilesMerger(dataFolderLocations, sortParameters.getTableName(),
    -            sortParameters.getDimColCount(),
    -            sortParameters.getComplexDimColCount(), sortParameters.getMeasureColCount(),
    -            sortParameters.getNoDictionaryCount(), sortParameters.getMeasureDataType(),
    -            sortParameters.getNoDictionaryDimnesionColumn(),
    -            sortParameters.getNoDictionarySortColumn());
    +            new TableFieldStat(sortParameters));
    --- End diff --
    
    I think the indentation is not correct


---

Mime
View raw message