carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...
Date Tue, 05 Dec 2017 16:19:15 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1605#discussion_r154997789
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/model/CarbonLoadModel.java
---
    @@ -172,6 +173,16 @@
     
       private boolean isAggLoadRequest;
     
    +  private CompactionType compactionType = CompactionType.NONE;
    --- End diff --
    
    This is added only for compaction, but load model is not for compaction. It is better
to refactor it.


---

Mime
View raw message