carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1565: [CARBONDATA-1518][Pre-Aggregate]Support creat...
Date Tue, 05 Dec 2017 15:58:39 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1565#discussion_r154990920
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/column/ColumnSchema.java
---
    @@ -439,6 +447,14 @@ public void setAggFunction(String aggFunction) {
         this.aggFunction = aggFunction;
       }
     
    +  public String getTimeSeriesFunction() {
    +    return timeSeriesFunction;
    +  }
    +
    +  public void setTimeSeriesFunction(String timeSeriesFunction) {
    +    this.timeSeriesFunction = timeSeriesFunction;
    --- End diff --
    
    should check it is not null


---

Mime
View raw message