carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1613: [CARBONDATA-1737] [CARBONDATA-1760] [PreAgg] ...
Date Tue, 05 Dec 2017 15:20:48 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1613#discussion_r154977627
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala
---
    @@ -493,4 +495,49 @@ object PreAggregateUtil {
         updatedPlan
       }
     
    +  /**
    +   * This method will start load process on the data map
    +   */
    +  def startDataLoadForDataMap(parentCarbonTable: CarbonTable,
    +      dataMapIdentifier: TableIdentifier,
    +      queryString: String,
    +      segmentToLoad: String,
    +      validateSegments: Boolean,
    +      sparkSession: SparkSession): Unit = {
    +    CarbonSession.threadSet(
    --- End diff --
    
    Do not use thread local to pass parameters, pass them explicitly to the command


---

Mime
View raw message