carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1605: [CARBONDATA-1526] [PreAgg] Added support to c...
Date Tue, 05 Dec 2017 14:47:08 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1605#discussion_r154966099
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAlterTableCompactionCommand.scala
---
    @@ -159,7 +161,14 @@ case class CarbonAlterTableCompactionCommand(
         // if system level compaction is enabled then only one compaction can run in the
system
         // if any other request comes at this time then it will create a compaction request
file.
         // so that this will be taken up by the compaction process which is executing.
    -    if (!isConcurrentCompactionAllowed) {
    +    if (carbonTable.isChildDataMap) {
    +      carbonLoadModel.setCompactionType(alterTableModel.compactionType.toUpperCase match
{
    --- End diff --
    
    change `setCompactionType` to accept enum instead of String


---

Mime
View raw message