carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1594: [CARBONDATA-1838] Refactor SortStepRowUtil to...
Date Mon, 04 Dec 2017 14:49:11 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1594#discussion_r154668281
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala
---
    @@ -128,7 +128,7 @@ object DataLoadProcessorStepOnSpark {
         val model: CarbonLoadModel = modelBroadcast.value.getCopyWithTaskNo(index.toString)
         val conf = DataLoadProcessBuilder.createConfiguration(model)
         val sortParameters = SortParameters.createSortParameters(conf)
    -
    +    val sortStepRowUtil = new SortStepRowUtil(sortParameters)
    --- End diff --
    
    Do we need to create this object everytime?


---

Mime
View raw message