carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1603: [CARBONDATA-1844] Add tablePath support when ...
Date Sun, 03 Dec 2017 16:22:34 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1603#discussion_r154528596
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -854,6 +854,7 @@
       public static final String DICTIONARY_EXCLUDE = "dictionary_exclude";
       public static final String DICTIONARY_INCLUDE = "dictionary_include";
       public static final String SORT_COLUMNS = "sort_columns";
    +  public static final String TABLE_PATH = "table_path";
    --- End diff --
    
    I think this will be confusion if we use 2 different words `tablePath` and `table_path`,
better use only one `tablePath`.


---

Mime
View raw message