carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1602: [CARBONDATA-1843] Add configuration to enable...
Date Sun, 03 Dec 2017 05:30:51 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1602#discussion_r154514538
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/parser/CarbonSparkSqlParser.scala
---
    @@ -18,6 +18,7 @@ package org.apache.spark.sql.parser
     
     import scala.collection.mutable
     
    +import org.antlr.v4.runtime.tree.TerminalNode
    --- End diff --
    
    I think it is better handle these validations at precreate table listener so that main
logic will be clean.


---

Mime
View raw message