Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: jackylk <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1571-carbondata@git.apache.org>
In-Reply-To: <git-pr-1571-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1571: [CARBONDATA-1811] [CTAS] Use StructType as sc...
Content-Type: text/plain
Message-Id: <20171130160156.E8EE0DFA0C@git1-us-west.apache.org>
Date: Thu, 30 Nov 2017 16:01:56 +0000 (UTC)
archived-at: Thu, 30 Nov 2017 16:01:58 -0000

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1571#discussion_r154118903
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/ColumnTableRelation.java ---
    @@ -0,0 +1,55 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.carbondata.core.metadata.schema.table;
    +
    +public class ColumnTableRelation {
    +  private String parentColumnName;
    +  private String parentColumnId;
    +  private String parentTableName;
    +  private String parentDatabaseName;
    +  private String parentTableId;
    +
    +  public ColumnTableRelation(String parentColumnName, String parentColumnId, String parentTableName,
    --- End diff --
    
    This class is moved directly from `case class ColumnTableRelation` in carbonTableSchemaCommon.scala in master
    I can change two member variables to `ParentColumnTableRelation`, but still not very intuitive. Any suggestion?


---