Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@carbondata.apache.org
From: sounakr <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1469-carbondata@git.apache.org>
In-Reply-To: <git-pr-1469-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1
Content-Type: text/plain
Message-Id: <20171127021422.E5A13DF9AE@git1-us-west.apache.org>
Date: Mon, 27 Nov 2017 02:14:22 +0000 (UTC)
archived-at: Mon, 27 Nov 2017 02:14:24 -0000

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1469#discussion_r153094337
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala ---
    @@ -95,12 +107,23 @@ case class CarbonIUDAnalysisRule(sparkSession: SparkSession) extends Rule[Logica
         def prepareTargetReleation(relation: UnresolvedRelation): SubqueryAlias = {
           val tupleId = UnresolvedAlias(Alias(UnresolvedFunction("getTupleId",
             Seq.empty, isDistinct = false), "tupleId")())
    +
    +      val localAlias = alias match {
    +        case Some(a) => Some(alias.toSeq)
    +        case _ => None
    +      }
           val projList = Seq(
    -        UnresolvedAlias(UnresolvedStar(Option(table.alias.toSeq))), tupleId)
    -      // include tuple id and rest of the required columns in subqury
    -      SubqueryAlias(table.alias.getOrElse(""),
    -        Project(projList, relation), Option(table.tableIdentifier))
    +        UnresolvedAlias(UnresolvedStar(localAlias)), tupleId)
    +
    +      val subqueryAlias =
    +        CarbonClassReflectionUtils
    +          .getSubqueryAlias(sparkSession,
    +            alias,
    +            Project(projList, relation),
    +            Some(table.tableIdentifier))
    +      subqueryAlias
    --- End diff --
    
    Done


---