Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 01376200D43 for ; Tue, 21 Nov 2017 19:10:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EF01B160BFC; Tue, 21 Nov 2017 18:10:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 38FB9160BE3 for ; Tue, 21 Nov 2017 19:10:52 +0100 (CET) Received: (qmail 6868 invoked by uid 500); 21 Nov 2017 18:10:51 -0000 Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@carbondata.apache.org Delivered-To: mailing list issues@carbondata.apache.org Received: (qmail 6859 invoked by uid 99); 21 Nov 2017 18:10:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Nov 2017 18:10:51 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 8FE5DDFBCA; Tue, 21 Nov 2017 18:10:50 +0000 (UTC) From: kumarvishal09 To: issues@carbondata.apache.org Reply-To: issues@carbondata.apache.org References: In-Reply-To: Subject: [GitHub] carbondata pull request #1542: [CARBONDATA-1757] [PreAgg] Fix for wrong avg ... Content-Type: text/plain Message-Id: <20171121181050.8FE5DDFBCA@git1-us-west.apache.org> Date: Tue, 21 Nov 2017 18:10:50 +0000 (UTC) archived-at: Tue, 21 Nov 2017 18:10:53 -0000 Github user kumarvishal09 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1542#discussion_r152357935 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -489,4 +489,44 @@ object PreAggregateUtil { } updatedPlan } + --- End diff -- This code is specific for inserting the data to aggregate table better to move this code in rules class ---