Return-Path: <issues-return-22418-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id D9CB3200D4B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 13 Nov 2017 02:29:11 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id A40C3160C05; Mon, 13 Nov 2017 01:29:06 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1CC44160BF1
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 13 Nov 2017 02:29:05 +0100 (CET)
Received: (qmail 25536 invoked by uid 500); 13 Nov 2017 01:29:00 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 25527 invoked by uid 99); 13 Nov 2017 01:29:00 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Nov 2017 01:29:00 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 2015DDFDAE; Mon, 13 Nov 2017 01:29:00 +0000 (UTC)
From: xuchuanyin <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1489-carbondata@git.apache.org>
In-Reply-To: <git-pr-1489-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1489: [CARBONDATA-1576][PREAGG][DATAMAP] Support Da...
Content-Type: text/plain
Message-Id: <20171113012900.2015DDFDAE@git1-us-west.apache.org>
Date: Mon, 13 Nov 2017 01:29:00 +0000 (UTC)
archived-at: Mon, 13 Nov 2017 01:29:12 -0000

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1489#discussion_r150433577
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java ---
    @@ -144,23 +144,40 @@ private TableDataMap getTableDataMap(String dataMapName,
        * Clear the datamap/datamaps of a table from memory
        * @param identifier Table identifier
        */
    -  public void clearDataMap(AbsoluteTableIdentifier identifier) {
    +  public void clearDataMaps(AbsoluteTableIdentifier identifier) {
         List<TableDataMap> tableDataMaps = allDataMaps.get(identifier.uniqueName());
         segmentRefreshMap.remove(identifier.uniqueName());
         if (tableDataMaps != null) {
    -      int i = 0;
           for (TableDataMap tableDataMap: tableDataMaps) {
             if (tableDataMap != null) {
               tableDataMap.clear();
               break;
             }
    -        i++;
           }
           allDataMaps.remove(identifier.uniqueName());
         }
       }
     
       /**
    +   * Clear the datamap/datamaps of a table from memory
    +   * @param identifier Table identifier
    +   */
    +  public void clearDataMap(AbsoluteTableIdentifier identifier, String dataMapName) {
    --- End diff --
    
    sorry, didn't notice the `break` before. That's fine~


---