Return-Path: <issues-return-22345-archive-asf-public=cust-asf.ponee.io@carbondata.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id F0CD0200D38
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sun, 12 Nov 2017 08:09:00 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id EF6F5160BF0; Sun, 12 Nov 2017 07:09:00 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 68C99160BD7
	for <archive-asf-public@cust-asf.ponee.io>; Sun, 12 Nov 2017 08:09:00 +0100 (CET)
Received: (qmail 55760 invoked by uid 500); 12 Nov 2017 07:08:59 -0000
Mailing-List: contact issues-help@carbondata.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@carbondata.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@carbondata.apache.org>
List-Post: <mailto:issues@carbondata.apache.org>
List-Id: <issues.carbondata.apache.org>
Reply-To: dev@carbondata.apache.org
Delivered-To: mailing list issues@carbondata.apache.org
Received: (qmail 55751 invoked by uid 99); 12 Nov 2017 07:08:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Nov 2017 07:08:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 77CB0DFBD3; Sun, 12 Nov 2017 07:08:59 +0000 (UTC)
From: ravipesala <git@git.apache.org>
To: issues@carbondata.apache.org
Reply-To: issues@carbondata.apache.org
References: <git-pr-1446-carbondata@git.apache.org>
In-Reply-To: <git-pr-1446-carbondata@git.apache.org>
Subject: [GitHub] carbondata pull request #1446: [CARBONDATA-1520] [PreAgg] Support pre-aggreg...
Content-Type: text/plain
Message-Id: <20171112070859.77CB0DFBD3@git1-us-west.apache.org>
Date: Sun, 12 Nov 2017 07:08:59 +0000 (UTC)
archived-at: Sun, 12 Nov 2017 07:09:01 -0000

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1446#discussion_r150402085
  
    --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java ---
    @@ -300,14 +302,30 @@ private AbsoluteTableIdentifier getAbsoluteTableIdentifier(Configuration configu
       @Override public List<InputSplit> getSplits(JobContext job) throws IOException {
         AbsoluteTableIdentifier identifier = getAbsoluteTableIdentifier(job.getConfiguration());
         SegmentUpdateStatusManager updateStatusManager = new SegmentUpdateStatusManager(identifier);
    +    CarbonTable carbonTable = getOrCreateCarbonTable(job.getConfiguration());
    +    if (null == carbonTable) {
    +      throw new IOException("Missing/Corrupt schema file for table.");
    +    }
    +    CarbonSessionInfo carbonSessionInfo = ThreadLocalSessionInfo.getCarbonSessionInfo();
    +    String aggregateTableSegments = "";
    +    Boolean validateAggregateTableSegments = true;
    +    if (carbonSessionInfo != null) {
    +      aggregateTableSegments = carbonSessionInfo.getSessionParams().getProperty(
    +          CarbonCommonConstants.CARBON_INPUT_SEGMENTS + identifier.getCarbonTableIdentifier()
    --- End diff --
    
    Better don't access here, just set the validation required or not from CarbonScanRDD and here use that boolean to  skip the validation.


---