carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xubo245 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1569: [CARBONDATA-1752] There are some scalastyle e...
Date Sun, 26 Nov 2017 12:15:50 GMT
GitHub user xubo245 opened a pull request:

    https://github.com/apache/carbondata/pull/1569

    [CARBONDATA-1752] There are some scalastyle error should be optimized in CarbonData

    
    There are some scalastyle error should be optimized in CarbonData, including removing
useless import, optimizing method definition and so on
    
    This PR remove some unused import like:
    
    ```
    import org.apache.carbondata.core.metadata.datatype.DecimalType
    import org.apache.carbondata.core.metadata.datatype.DataType;
    
    ```
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     NO
     - [ ] Any backward compatibility impacted?
     No
     - [ ] Document update required?
    No
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xubo245/carbondata fixStyle3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1569
    
----
commit 9f4dc338acc4745ab72d3cae8694b9d768306e5b
Author: xubo245 <601450868@qq.com>
Date:   2017-11-26T12:10:30Z

    [CARBONDATA-1752] There are some scalastyle error should be optimized in CarbonData
    
    There are some scalastyle error should be optimized in CarbonData, including removing
useless import, optimizing method definition and so on
    
    This PR remove some unused import like:
    import org.apache.carbondata.core.metadata.datatype.DecimalType
    import org.apache.carbondata.core.metadata.datatype.DataType;

----


---

Mime
View raw message