carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kunal642 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1542: [CARBONDATA-1757] [PreAgg] Fix for wrong avg ...
Date Tue, 21 Nov 2017 07:31:03 GMT
GitHub user kunal642 opened a pull request:

    https://github.com/apache/carbondata/pull/1542

    [CARBONDATA-1757] [PreAgg] Fix for wrong avg values after pre-agg table creation

    when a sum/count aggregation function is applied on the same column along with avg. The
plan that was getting transformed was adding 2 columns for sum/count which resulted in wrong
data being inserted.
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [X] Any interfaces changed?
     No
     - [X] Any backward compatibility impacted?
     No
     - [X] Document update required?
    No
     - [X] Testing done
    Test case added
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
    No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kunal642/carbondata pre_agg_avg_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1542.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1542
    
----
commit f05ba4faabc70c19574ed200ddb88909d69cf6e3
Author: kunal642 <kunalkapoor642@gmail.com>
Date:   2017-11-21T07:25:25Z

    fixed wrong avg count bug when a sum/count aggregation function is applied on the same
column along with avg.
    The plan that was getting transformed was adding 2 columns for sum/count which resulted
in wrong data being inserted.

----


---

Mime
View raw message