carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dhatchayani <...@git.apache.org>
Subject [GitHub] carbondata pull request #1483: [CARBONDATA-1699][FILTER] Filter is not worki...
Date Fri, 10 Nov 2017 14:25:11 GMT
GitHub user dhatchayani opened a pull request:

    https://github.com/apache/carbondata/pull/1483

    [CARBONDATA-1699][FILTER] Filter is not working properly

    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [X] Testing done
              UT Added
            
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
    
    
    Issue:
    When having duplicate values in the data, filter results are wrong
    
    Scenario:
    Load data like below
    a,11234567489.7976
    b,11234567489.7976000000
    Filter query on double_column = 11234567489.7976
    Result - only either one of the row is selected
    Actual Result - all the two rows should be selected
    
    Logic of binary search while applying filter is changed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhatchayani/incubator-carbondata binary_search

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1483
    
----
commit 5ced3843655b56306bd3aa432d92cecc8b1fc650
Author: dhatchayani <dhatcha.official@gmail.com>
Date:   2017-11-10T14:21:24Z

    [CARBONDATA-1699][FILTER] Filter is not working properly

----


---

Mime
View raw message