carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1467: [CARBONDATA-1669] Clean up code in CarbonData...
Date Sun, 05 Nov 2017 16:47:41 GMT
GitHub user jackylk opened a pull request:

    https://github.com/apache/carbondata/pull/1467

    [CARBONDATA-1669] Clean up code in CarbonDataRDDFactory

    Inside CarbonDataRDDFactory.loadCarbonData, there are many function defined inside function,
makes the loading logic very hard to read
    This PR improves its readability
    
     - [X] Any interfaces changed?
     No
    
     - [X] Any backward compatibility impacted?
     No
    
     - [X] Document update required?
    No
    
     - [X] Testing done
    No new testcase is required
    
     - [X] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA. 
    NA

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jackylk/incubator-carbondata refactor_loaddata

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1467
    
----
commit a35b8a2a81c54df100738879a1ec66004efc8ca7
Author: Jacky Li <jacky.likun@qq.com>
Date:   2017-11-05T12:35:09Z

    remove isTableSplitPartition

commit df65121987660b455201ab99abbe063c93e4eb8c
Author: Jacky Li <jacky.likun@qq.com>
Date:   2017-11-05T16:41:29Z

    refactor load data

----


---

Mime
View raw message