carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ManoharVanam <...@git.apache.org>
Subject [GitHub] carbondata pull request #1563: [CARBONDATA-1592] Refactored CarbonSession
Date Wed, 29 Nov 2017 09:22:45 GMT
Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1563#discussion_r153730143
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
---
    @@ -140,10 +140,15 @@ object CarbonReflectionUtils {
     
       def getSessionState(sparkContext: SparkContext, carbonSession: Object): Any = {
         if (sparkContext.version.startsWith("2.1")) {
    -      createObject("org.apache.spark.sql.hive.CarbonSessionState", carbonSession)._1
    +      val className = sparkContext.conf
    +        .get("spark.carbon.sessionstate.classname", "org.apache.spark.sql.hive.CarbonSessionState")
    --- End diff --
    
    makespark.carbon.sessionstate.classname string in CarbonCommonConstant instead of hard
coding it here. --- ok
    
    and change org.apache.spark.sql.hive.CarbonSessionState to CarbonSessionState.getClass.getName
--  CarbonSessionState belongs to spark2 module so we cannot access from spark-common module


---

Mime
View raw message