carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1587: [CARBONDATA-1835] Fix null exception when get...
Date Wed, 29 Nov 2017 08:49:18 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1587#discussion_r153722661
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonGetTableDetailCommand.scala
---
    @@ -42,18 +42,22 @@ case class CarbonGetTableDetailCommand(
     
       override def processData(sparkSession: SparkSession): Seq[Row] = {
         val storePath = CarbonProperties.getStorePath
    -    tableNames.map { tablename =>
    -      val absoluteTableIdentifier =
    -        AbsoluteTableIdentifier.from(storePath, databaseName.toLowerCase, tablename.toLowerCase)
    -      val carbonTableIdentifier = absoluteTableIdentifier.getCarbonTableIdentifier
    -      val carbonTable = CarbonEnv.getCarbonTable(Option(carbonTableIdentifier.getDatabaseName),
    -        carbonTableIdentifier.getTableName)(sparkSession)
    +    if (null != tableNames) {
    --- End diff --
    
    suggest to change tableNames to type Option[Seq[String]] instead of using null


---

Mime
View raw message