carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <...@git.apache.org>
Subject [GitHub] carbondata pull request #1584: [CARBONDATA-1827] Added S3 Implementation
Date Wed, 29 Nov 2017 04:40:33 GMT
Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1584#discussion_r153692578
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
    @@ -81,24 +77,22 @@ public static FileHolder getFileHolder(FileType fileType) {
           case HDFS:
           case ALLUXIO:
           case VIEWFS:
    -      case S3:
             return new DFSFileHolderImpl();
    +      case S3:
    +        return new S3FileHolderImpl();
           default:
             return new FileHolderImpl();
         }
       }
     
       public static FileType getFileType(String path) {
    -    String lowerPath = path.toLowerCase();
    --- End diff --
    
    Any reason why converting to lower case is removed.


---

Mime
View raw message