carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mohammadshahidkhan <...@git.apache.org>
Subject [GitHub] carbondata pull request #1584: [CARBONDATA-1827] Added S3 Implementation
Date Wed, 29 Nov 2017 04:34:47 GMT
Github user mohammadshahidkhan commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1584#discussion_r153691909
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
    @@ -162,6 +161,12 @@
     
       public static final String S3A_PREFIX = "s3a://";
     
    +
    +  /**
    +   * VIEWS3URL_PREFIX
    +   */
    +  public static final String S3URL_PREFIX = "s3a://";
    --- End diff --
    
    S3A_PREFIX  and S3URL_PREFIX both have same constant.
    Please remove once of them.


---

Mime
View raw message