carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From manishgupta88 <...@git.apache.org>
Subject [GitHub] carbondata pull request #1563: [CARBONDATA-1592] Refactored CarbonSession
Date Mon, 27 Nov 2017 13:19:06 GMT
Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1563#discussion_r153193171
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonSessionState.scala
---
    @@ -146,22 +149,31 @@ class CarbonSessionState(sparkSession: SparkSession) extends HiveSessionState(sp
     
       override lazy val optimizer: Optimizer = new CarbonOptimizer(catalog, conf, experimentalMethods)
     
    +  def extendedAnalyzerRules: Seq[Rule[LogicalPlan]] = Nil
    +  def internalAnalyzerRules: Seq[Rule[LogicalPlan]] = {
    --- End diff --
    
    can we rename the method from internalAnalyzerRules to analyzerRules?...As we already
have 1 method with name extendedAnalyzerRules, so this name looks more suitable to me


---

Mime
View raw message