carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] carbondata pull request #1469: [CARBONDATA-1552][Spark-2.2 Integration] Spar...
Date Mon, 27 Nov 2017 06:59:12 GMT
Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1469#discussion_r153117393
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
---
    @@ -58,6 +57,8 @@ object CarbonPreInsertionCasts extends Rule[LogicalPlan] {
             )
         }
         if (child.output.size >= relation.carbonRelation.output.size) {
    +      sparkVersion21 = !CarbonClassReflectionUtils.hasField("query", InsertIntoCarbonTable)
    --- End diff --
    
    I think we can add a parameter called "SPARK_VERSION" into CarbonProperties, when start
CarbonSession, set this parameter as SparkContext.version, and then we can use this parameter
in any places


---

Mime
View raw message