carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...
Date Sun, 26 Nov 2017 12:10:10 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1508#discussion_r153067988
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala
---
    @@ -736,6 +739,45 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession)
extends Rule
       }
     }
     
    +object CarbonPreAggregateDataLoadingRules extends Rule[LogicalPlan] {
    +
    +  override def apply(plan: LogicalPlan): LogicalPlan = {
    +
    +    plan transform {
    +      case aggregate@Aggregate(_, aExp, _) =>
    +        val isLoadPlan = aExp.exists(_.name.equalsIgnoreCase("preAggLoad"))
    --- End diff --
    
    Even this condition also move to `case ` block


---

Mime
View raw message