carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ManoharVanam <...@git.apache.org>
Subject [GitHub] carbondata pull request #1560: [CARBONDATA-1804] Support Plug-gable File Ope...
Date Sun, 26 Nov 2017 03:30:29 GMT
Github user ManoharVanam commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1560#discussion_r153059129
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonFileMetastore.scala
---
    @@ -353,14 +355,14 @@ class CarbonFileMetastore extends CarbonMetaStore {
         val schemaFilePath = carbonTablePath.getSchemaFilePath
         val schemaMetadataPath = CarbonTablePath.getFolderContainingFile(schemaFilePath)
         tableInfo.setMetaDataFilepath(schemaMetadataPath)
    -    val fileType = FileFactory.getFileType(schemaMetadataPath)
    -    if (!FileFactory.isFileExist(schemaMetadataPath, fileType)) {
    -      FileFactory.mkdirs(schemaMetadataPath, fileType)
    -    }
    -    val thriftWriter = new ThriftWriter(schemaFilePath, false)
    -    thriftWriter.open(FileWriteOperation.OVERWRITE)
    -    thriftWriter.write(thriftTableInfo)
    -    thriftWriter.close()
    +      val fileType = FileFactory.getFileType(schemaMetadataPath)
    --- End diff --
    
    ok



---

Mime
View raw message