carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1
Date Thu, 23 Nov 2017 06:29:19 GMT
Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1469#discussion_r152728991
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/internal/CarbonSqlConf.scala
---
    @@ -32,76 +32,6 @@ class CarbonSQLConf(sparkSession: SparkSession) {
       /**
        * To initialize dynamic param defaults along with usage docs
        */
    -  def addDefaultCarbonParams(): Unit = {
    -    val ENABLE_UNSAFE_SORT =
    -      SQLConfigBuilder(CarbonCommonConstants.ENABLE_UNSAFE_SORT)
    -        .doc("To enable/ disable unsafe sort.")
    -        .booleanConf
    -        .createWithDefault(carbonProperties.getProperty(CarbonCommonConstants.ENABLE_UNSAFE_SORT,
    -          CarbonCommonConstants.ENABLE_UNSAFE_SORT_DEFAULT).toBoolean)
    -    val CARBON_CUSTOM_BLOCK_DISTRIBUTION =
    -      SQLConfigBuilder(CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION)
    -        .doc("To enable/ disable carbon custom block distribution.")
    -        .booleanConf
    -        .createWithDefault(carbonProperties
    -          .getProperty(CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION,
    -            CarbonCommonConstants.CARBON_CUSTOM_BLOCK_DISTRIBUTION_DEFAULT).toBoolean)
    -    val BAD_RECORDS_LOGGER_ENABLE =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORDS_LOGGER_ENABLE)
    -        .doc("To enable/ disable carbon bad record logger.")
    -        .booleanConf
    -        .createWithDefault(CarbonLoadOptionConstants
    -          .CARBON_OPTIONS_BAD_RECORDS_LOGGER_ENABLE_DEFAULT.toBoolean)
    -    val BAD_RECORDS_ACTION =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORDS_ACTION)
    -        .doc("To configure the bad records action.")
    -        .stringConf
    -        .createWithDefault(carbonProperties
    -          .getProperty(CarbonCommonConstants.CARBON_BAD_RECORDS_ACTION,
    -            CarbonCommonConstants.CARBON_BAD_RECORDS_ACTION_DEFAULT))
    -    val IS_EMPTY_DATA_BAD_RECORD =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_IS_EMPTY_DATA_BAD_RECORD)
    -        .doc("Property to decide weather empty data to be considered bad/ good record.")
    -        .booleanConf
    -        .createWithDefault(CarbonLoadOptionConstants.CARBON_OPTIONS_IS_EMPTY_DATA_BAD_RECORD_DEFAULT
    -          .toBoolean)
    -    val SORT_SCOPE =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_SORT_SCOPE)
    -        .doc("Property to specify sort scope.")
    -        .stringConf
    -        .createWithDefault(carbonProperties.getProperty(CarbonCommonConstants.LOAD_SORT_SCOPE,
    -          CarbonCommonConstants.LOAD_SORT_SCOPE_DEFAULT))
    -    val BATCH_SORT_SIZE_INMB =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_BATCH_SORT_SIZE_INMB)
    -        .doc("Property to specify batch sort size in MB.")
    -        .stringConf
    -        .createWithDefault(carbonProperties
    -          .getProperty(CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB,
    -            CarbonCommonConstants.LOAD_BATCH_SORT_SIZE_INMB_DEFAULT))
    -    val SINGLE_PASS =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_SINGLE_PASS)
    -        .doc("Property to enable/disable single_pass.")
    -        .booleanConf
    -        .createWithDefault(CarbonLoadOptionConstants.CARBON_OPTIONS_SINGLE_PASS_DEFAULT.toBoolean)
    -    val BAD_RECORD_PATH =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_BAD_RECORD_PATH)
    -        .doc("Property to configure the bad record location.")
    -        .stringConf
    -        .createWithDefault(carbonProperties.getProperty(CarbonCommonConstants.CARBON_BADRECORDS_LOC,
    -          CarbonCommonConstants.CARBON_BADRECORDS_LOC_DEFAULT_VAL))
    -    val GLOBAL_SORT_PARTITIONS =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_GLOBAL_SORT_PARTITIONS)
    -        .doc("Property to configure the global sort partitions.")
    -        .stringConf
    -        .createWithDefault(carbonProperties
    -          .getProperty(CarbonCommonConstants.LOAD_GLOBAL_SORT_PARTITIONS,
    -            CarbonCommonConstants.LOAD_GLOBAL_SORT_PARTITIONS_DEFAULT))
    -    val DATEFORMAT =
    -      SQLConfigBuilder(CarbonLoadOptionConstants.CARBON_OPTIONS_DATEFORMAT)
    -        .doc("Property to configure data format for date type columns.")
    -        .stringConf
    -        .createWithDefault(CarbonLoadOptionConstants.CARBON_OPTIONS_DATEFORMAT_DEFAULT)
    -  }
    --- End diff --
    
    why does it need to remove above lines?


---

Mime
View raw message