carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] carbondata pull request #1469: [WIP] Spark-2.2 Carbon Integration - Phase 1
Date Thu, 23 Nov 2017 04:00:02 GMT
Github user zzcclp commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1469#discussion_r152721088
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonSession.scala ---
    @@ -42,15 +42,46 @@ class CarbonSession(@transient val sc: SparkContext,
         this(sc, None)
       }
     
    +
    +  // SessionStateCodeGenerateFactory.init(sc.version)
    +  // CarbonOptimizerCodeGenerateFactory.init(sc.version)
    +  // val carbonDefaultOptimizer = CarbonOptimizerCodeGenerateFactory.getInstance()
    +  //  .carbonoptimizerFactory.createCarbonOptimizer()
    +  //  @transient
    +  //  override lazy val sessionState: SessionState = new CarbonSessionState(this)
    +
    +
    +
    +  def getSessionState(sparkContext: SparkContext): SessionState = {
    +    if (sparkContext.version.contains("2.1")) {
    --- End diff --
    
    It'd better use sparkContext.version.**startsWith**("2.1"), if version = 2.2.1, contains("2.1")
will return  true.


---

Mime
View raw message