carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1508: [CARBONDATA-1738] [PreAgg] Block direct inser...
Date Wed, 22 Nov 2017 15:30:44 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1508#discussion_r152597828
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/execution/command/CarbonHiveCommands.scala
---
    @@ -95,8 +95,14 @@ object CarbonSetCommand {
           }
         } else if (key.startsWith(CarbonCommonConstants.VALIDATE_CARBON_INPUT_SEGMENTS))
{
           sessionParams.addProperty(key.toLowerCase(), value)
    +    } else if (key.startsWith(CarbonCommonConstants.IS_INTERNAL_LOAD_CALL)) {
    --- End diff --
    
    I don't think it is required to use `set command` for this internal call. we are not going
to give the option to load the aggregate table as it may corrupt the table.


---

Mime
View raw message