carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zzcclp <...@git.apache.org>
Subject [GitHub] carbondata issue #1540: [CARBONDATA-1784] clear column group code
Date Wed, 22 Nov 2017 08:30:57 GMT
Github user zzcclp commented on the issue:

    https://github.com/apache/carbondata/pull/1540
  
    @chenliang613 , it seems there are many places about column group need to be removed,
for example:
    in TableNewProcessor.process():
    
    `checkColGroupsValidity(cm.columnGroups, allColumns, highCardinalityDims)`
    `updateColumnGroupsInFields(cm.columnGroups, allColumns)`
    
    Method 'checkColGroupsValidity' and 'updateColumnGroupsInFields' also can be removed.
    
    Method 'CarbonDDLSqlParser.updateColumnGroupsInField' also can be removed.
    
    Suggestion: in CarbonDDLSqlParserprepareTableModel, we can throw an exception when user
define 'column_groups' in TBLPROPERTIES.
    



---

Mime
View raw message