carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1471: [CARBONDATA-1544][Datamap] Datamap FineGrain ...
Date Sat, 18 Nov 2017 06:17:56 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1471#discussion_r151830196
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java
---
    @@ -463,20 +426,24 @@ protected void writeIndexFile() throws IOException, CarbonDataWriterException
{
        * @throws CarbonDataWriterException
        */
       protected void closeExecutorService() throws CarbonDataWriterException {
    -    executorService.shutdown();
         try {
    -      executorService.awaitTermination(2, TimeUnit.HOURS);
    -    } catch (InterruptedException e) {
    -      throw new CarbonDataWriterException(e.getMessage());
    -    }
    -    for (int i = 0; i < executorServiceSubmitList.size(); i++) {
    +      listener.finish();
    +      executorService.shutdown();
           try {
    -        executorServiceSubmitList.get(i).get();
    +        executorService.awaitTermination(2, TimeUnit.HOURS);
           } catch (InterruptedException e) {
             throw new CarbonDataWriterException(e.getMessage());
    -      } catch (ExecutionException e) {
    -        throw new CarbonDataWriterException(e.getMessage());
           }
    +      for (int i = 0; i < executorServiceSubmitList.size(); i++) {
    +        executorServiceSubmitList.get(i).get();
    +      }
    +    } catch (InterruptedException e) {
    +      throw new CarbonDataWriterException(e.getMessage());
    +    } catch (ExecutionException e) {
    +      throw new CarbonDataWriterException(e.getMessage());
    +    } catch (IOException e) {
    +      LOGGER.error(e, "Error while writing datamap");
    +      throw new CarbonDataWriterException(e.getMessage());
    --- End diff --
    
    ok


---

Mime
View raw message