carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipesala <...@git.apache.org>
Subject [GitHub] carbondata pull request #1494: [CARBONDATA-1706] Making index merge DDL inse...
Date Thu, 16 Nov 2017 12:07:37 GMT
Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1494#discussion_r151395683
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
    @@ -851,13 +851,20 @@ object CommonUtil {
       def mergeIndexFiles(sparkContext: SparkContext,
           segmentIds: Seq[String],
           tablePath: String,
    -      carbonTable: CarbonTable): Unit = {
    -    if (CarbonProperties.getInstance().getProperty(
    -      CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT,
    -      CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT_DEFAULT).toBoolean) {
    +      carbonTable: CarbonTable,
    +      mergeIndexProperty: Boolean): Unit = {
    +    if (mergeIndexProperty) {
           new CarbonMergeFilesRDD(sparkContext, AbsoluteTableIdentifier.from(tablePath,
             carbonTable.getDatabaseName, carbonTable.getFactTableName).getTablePath,
             segmentIds).collect()
    +    } else {
    +      if (CarbonProperties.getInstance().getProperty(
    +        CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT,
    +        CarbonCommonConstants.CARBON_MERGE_INDEX_IN_SEGMENT_DEFAULT).toBoolean) {
    --- End diff --
    
    what if the property passed by user is wrong? can we use default if user passes wrong
property


---

Mime
View raw message