carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gvramana <...@git.apache.org>
Subject [GitHub] carbondata pull request #1432: [CARBONDATA-1608]Support Column Comment for C...
Date Tue, 14 Nov 2017 15:22:44 GMT
Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1432#discussion_r150863854
  
    --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/CarbonDescribeFormattedCommand.scala
---
    @@ -65,6 +65,7 @@ private[sql] case class CarbonDescribeFormattedCommand(
         val dims = relation.metaData.dims.map(x => x.toLowerCase)
         var results: Seq[(String, String, String)] = child.schema.fields.map { field =>
           val fieldName = field.name.toLowerCase
    +      val colComment = field.getComment().getOrElse("null")
    --- End diff --
    
    Also needs to make sure that "desc table" also works. As spark/Hive supports accordingly,
need to make it consistant


---

Mime
View raw message