carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1481: [CARBONDATA-1576] Added create datamap parser...
Date Mon, 13 Nov 2017 09:14:12 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1481#discussion_r150480075
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchema.java
---
    @@ -255,21 +255,15 @@ public void readFields(DataInput in) throws IOException {
        * Below method will be used to build child schema object which will be stored in
        * parent table
        *
    -   * @param className
    -   * @param databaseName
    -   * @param queryString
    -   * @param queryType
    -   *
    -   * @return datamap schema
        */
    -  public DataMapSchema buildChildSchema(String className, String databaseName, String
queryString,
    -      String queryType) {
    +  public DataMapSchema buildChildSchema(String dataMapName, String className, String
databaseName,
    --- End diff --
    
    Is the dataMapName is for child schema? Please modify the parameter name or describe in
function comment in line 255


---

Mime
View raw message