carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1481: [CARBONDATA-1576] Added create datamap parser...
Date Mon, 13 Nov 2017 09:13:32 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1481#discussion_r150479458
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
---
    @@ -322,17 +322,22 @@
         for (DataMapSchema wrapperChildSchema : wrapperChildSchemaList) {
           org.apache.carbondata.format.DataMapSchema thriftChildSchema =
               new org.apache.carbondata.format.DataMapSchema();
    -      org.apache.carbondata.format.RelationIdentifier relationIdentifier =
    -          new org.apache.carbondata.format.RelationIdentifier();
    -      relationIdentifier
    -          .setDatabaseName(wrapperChildSchema.getRelationIdentifier().getDatabaseName());
    -      relationIdentifier.setTableName(wrapperChildSchema.getRelationIdentifier().getTableName());
    -      relationIdentifier.setTableId(wrapperChildSchema.getRelationIdentifier().getTableId());
    -      thriftChildSchema.setRelationIdentifire(relationIdentifier);
    +      if (wrapperChildSchema.getRelationIdentifier() != null) {
    +        org.apache.carbondata.format.RelationIdentifier relationIdentifier =
    +            new org.apache.carbondata.format.RelationIdentifier();
    +        relationIdentifier
    +            .setDatabaseName(wrapperChildSchema.getRelationIdentifier().getDatabaseName());
    --- End diff --
    
    move to previous line, move parameter to next line


---

Mime
View raw message