carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xuchuanyin <...@git.apache.org>
Subject [GitHub] carbondata pull request #1489: [CARBONDATA-1576][PREAGG][DATAMAP] Support Da...
Date Mon, 13 Nov 2017 01:29:00 GMT
Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1489#discussion_r150433577
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java
---
    @@ -144,23 +144,40 @@ private TableDataMap getTableDataMap(String dataMapName,
        * Clear the datamap/datamaps of a table from memory
        * @param identifier Table identifier
        */
    -  public void clearDataMap(AbsoluteTableIdentifier identifier) {
    +  public void clearDataMaps(AbsoluteTableIdentifier identifier) {
         List<TableDataMap> tableDataMaps = allDataMaps.get(identifier.uniqueName());
         segmentRefreshMap.remove(identifier.uniqueName());
         if (tableDataMaps != null) {
    -      int i = 0;
           for (TableDataMap tableDataMap: tableDataMaps) {
             if (tableDataMap != null) {
               tableDataMap.clear();
               break;
             }
    -        i++;
           }
           allDataMaps.remove(identifier.uniqueName());
         }
       }
     
       /**
    +   * Clear the datamap/datamaps of a table from memory
    +   * @param identifier Table identifier
    +   */
    +  public void clearDataMap(AbsoluteTableIdentifier identifier, String dataMapName) {
    --- End diff --
    
    sorry, didn't notice the `break` before. That's fine~


---

Mime
View raw message