carbondata-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jackylk <...@git.apache.org>
Subject [GitHub] carbondata pull request #1485: [CARBONDATA-1572][Streaming] Add test case fo...
Date Sun, 12 Nov 2017 13:58:56 GMT
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1485#discussion_r150411392
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/api/CarbonStore.scala
---
    @@ -74,8 +74,16 @@ object CarbonStore {
                 Row(
                   load.getLoadName,
                   load.getLoadStatus,
    -              new java.sql.Timestamp(load.getLoadStartTime),
    -              new java.sql.Timestamp(load.getLoadEndTime),
    +              if (load.getLoadStartTime == -1) {
    --- End diff --
    
    I think it is better to move `if` block before line 74, like `mergedTo`


---

Mime
View raw message